Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262841AbVDHOyu (ORCPT ); Fri, 8 Apr 2005 10:54:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262839AbVDHOyu (ORCPT ); Fri, 8 Apr 2005 10:54:50 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:42253 "EHLO pfepb.post.tele.dk") by vger.kernel.org with ESMTP id S262843AbVDHOyp (ORCPT ); Fri, 8 Apr 2005 10:54:45 -0400 Date: Fri, 8 Apr 2005 16:55:27 +0200 From: Sam Ravnborg To: Ian Molton Cc: Greg KH , linux-kernel@vger.kernel.org Subject: Re: PATCH add support for system on chip (SoC) devices. Message-ID: <20050408145527.GB8227@mars.ravnborg.org> References: <42569300.7070008@f2s.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42569300.7070008@f2s.com> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 18 On Fri, Apr 08, 2005 at 03:19:44PM +0100, Ian Molton wrote: > Hi. > > This patch add support for a new 'System on Chip' or SoC bus type. Hi Ian. A few general comments. 1) Please add kernel-doc style comments for all exported functions 2) Keep source within 80 coloumns 3) Do not use extern in front of function definition Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/