Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262955AbVDHVLT (ORCPT ); Fri, 8 Apr 2005 17:11:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262956AbVDHVLT (ORCPT ); Fri, 8 Apr 2005 17:11:19 -0400 Received: from cantor.suse.de ([195.135.220.2]:16806 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S262955AbVDHVLP (ORCPT ); Fri, 8 Apr 2005 17:11:15 -0400 To: Benjamin Herrenschmidt Cc: Dave Airlie , Linux Kernel list , Linux Fbdev development list Subject: Re: [PATCH] radeonfb: (#2) Implement proper workarounds for PLL accesses References: <1110519743.5810.13.camel@gaston> <1110672745.5787.60.camel@gaston> <1112743901.9568.67.camel@gaston> <1112827655.9518.194.camel@gaston> <21d7e9970504071422349426eb@mail.gmail.com> <1112914795.9568.320.camel@gaston> <1112923186.9567.349.camel@gaston> From: Andreas Schwab X-Yow: If I pull this SWITCH I'll be RITA HAYWORTH!! Or a SCIENTOLOGIST! Date: Fri, 08 Apr 2005 23:11:12 +0200 In-Reply-To: <1112923186.9567.349.camel@gaston> (Benjamin Herrenschmidt's message of "Fri, 08 Apr 2005 11:19:46 +1000") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 34 Benjamin Herrenschmidt writes: > On Fri, 2005-04-08 at 01:58 +0200, Andreas Schwab wrote: >> Benjamin Herrenschmidt writes: >> >> > Yes, that's very extreme, I suspect somebody is banging on set_par or >> > something like that. >> >> fb_setcolreg is it. > > Ok, what about that patch: > > --- > > This patch adds to the fbdev interface a set_cmap callback that allow > the driver to "batch" palette changes. This is useful for drivers like > radeonfb which might require lenghtly workarounds on palette accesses, > thus allowing to factor out those workarounds efficiently. This makes it better. But there is still a delay of half a second, and there is an annoying flicker when switching from X to the console. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/