Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261243AbVDIBnq (ORCPT ); Fri, 8 Apr 2005 21:43:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261245AbVDIBnq (ORCPT ); Fri, 8 Apr 2005 21:43:46 -0400 Received: from mail.dif.dk ([193.138.115.101]:54672 "EHLO saerimmer.dif.dk") by vger.kernel.org with ESMTP id S261243AbVDIBno (ORCPT ); Fri, 8 Apr 2005 21:43:44 -0400 Date: Sat, 9 Apr 2005 03:46:17 +0200 (CEST) From: Jesper Juhl To: Andrew Morton Cc: Jesper Juhl , linux-kernel@vger.kernel.org, mingo@redhat.com, arjan@infradead.org, ecashin@noserose.net, greg@kroah.com, axboe@suse.de Subject: Re: [PATCH] make mempool_destroy resilient against NULL pointers. In-Reply-To: <20050408184121.0a498a3d.akpm@osdl.org> Message-ID: References: <20050408184121.0a498a3d.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 24 On Fri, 8 Apr 2005, Andrew Morton wrote: > Jesper Juhl wrote: > > > > > > General rule (as I understand it) is that functions that free resources > > should handle being passed NULL pointers - mempool_destroy() will > > currently explode if passed a NULL pointer, the patch below makes it safe > > to pass it NULL. > > The best response to mempool_destroy(0) is an oops. There's no legitimate > reason for doing it. > Ok, ignore the patch then. -- Jesper - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/