Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261362AbVDISD5 (ORCPT ); Sat, 9 Apr 2005 14:03:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261364AbVDISD5 (ORCPT ); Sat, 9 Apr 2005 14:03:57 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:7684 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S261362AbVDISDx (ORCPT ); Sat, 9 Apr 2005 14:03:53 -0400 Date: Sat, 9 Apr 2005 20:03:52 +0200 From: Adrian Bunk To: Andrew Morton Cc: ambx1@neo.rr.com, linux-kernel@vger.kernel.org Subject: [2.6 patch] drivers/pnp/pnpbios/rsparser.c: fix an array overflow Message-ID: <20050409180352.GD3632@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 28 This patch fixes an array overflow found by the Coverity checker. Signed-off-by: Adrian Bunk --- This patch was already sent on: - 27 Mar 2005 --- linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c.old 2005-03-23 03:04:17.000000000 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/pnp/pnpbios/rsparser.c 2005-03-23 03:05:21.000000000 +0100 @@ -72,7 +72,9 @@ pnpbios_parse_allocated_dmaresource(struct pnp_resource_table * res, int dma) { int i = 0; - while (!(res->dma_resource[i].flags & IORESOURCE_UNSET) && i < PNP_MAX_DMA) i++; + while (i < PNP_MAX_DMA && + !(res->dma_resource[i].flags & IORESOURCE_UNSET)) + i++; if (i < PNP_MAX_DMA) { res->dma_resource[i].flags = IORESOURCE_DMA; // Also clears _UNSET flag if (dma == -1) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/