From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andreas Steinmetz <ast@domdv.de>
Subject: Re: Oops in swsusp
Date: Mon, 11 Apr 2005 08:59:00 +0200
User-Agent: KMail/1.7.1
Cc: Pavel Machek <pavel@ucw.cz>,
       Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
References: <4259B425.4090105@domdv.de>
In-Reply-To: <4259B425.4090105@domdv.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-2"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200504110859.00961.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 27

Hi,

On Monday, 11 of April 2005 01:17, Andreas Steinmetz wrote:
> Pavel,
> during testing of the encrypted swsusp_image on x86_64 I did get an Oops
> from time to time at memcpy+11 called from swsusp_save+1090 which turns
> out to be the memcpy in copy_data_pages() of swsusp.c.
> The Oops is caused by a NULL pointer (I don't remember if it was source
> or destination).

It's quite important, however.  If it's the destination, it's probably a bug in
swsusp.  Otherwise, the problem is more serious.  Could you, please,
add BUG_ON(!pbe->address) right before the memcpy() and retest?

Greets,
Rafael


-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/