Return-Path: <linux-kernel-owner+willy=40w.ods.org-S261964AbVDKW02@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S261964AbVDKW02 (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 11 Apr 2005 18:26:28 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261979AbVDKWYh
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 11 Apr 2005 18:24:37 -0400
Received: from fire.osdl.org ([65.172.181.4]:55250 "EHLO smtp.osdl.org")
	by vger.kernel.org with ESMTP id S261972AbVDKWWn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Apr 2005 18:22:43 -0400
Date: Mon, 11 Apr 2005 15:22:43 -0700
From: Andrew Morton <akpm@osdl.org>
To: Borislav Petkov <petkov@uni-muenster.de>
Cc: jamagallon@able.es, linux-kernel@vger.kernel.org,
       Stas Sergeev <stsp@aknet.ru>
Subject: Re: 2.6.12-rc2-mm3
Message-Id: <20050411152243.22835d96.akpm@osdl.org>
In-Reply-To: <200504112359.40487.petkov@uni-muenster.de>
References: <20050411012532.58593bc1.akpm@osdl.org>
	<1113209793l.7664l.1l@werewolf.able.es>
	<20050411024322.786b83de.akpm@osdl.org>
	<200504112359.40487.petkov@uni-muenster.de>
X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3268
Lines: 81

Borislav Petkov <petkov@uni-muenster.de> wrote:
>
> On Monday 11 April 2005 11:43, Andrew Morton wrote:
> > (Please do reply-to-all)
> >
> > "J.A. Magallon" <jamagallon@able.es> wrote:
> > > On 04.11, Andrew Morton wrote:
> > >  > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-r
> > >  >c2/2.6.12-rc2-mm3/
> > >
> > >  Is this not needed anymore ?
> > >
> > >  --- 25/arch/i386/kernel/entry.S~nmi_stack_correct-fix	2005-04-05
> > > 00:02:48.000000000 -0700 +++ 25-akpm/arch/i386/kernel/entry.S	2005-04-05
> > > 00:02:48.000000000 -0700
> >
> > Hopefully not. fix-crash-in-entrys-restore_all.patch works around the
> > problem. -
> 
> Hello Andrew,
> I don't know whether you remember the mysterious crashes I was telling you 
> about last week and me rookiesh-ly trying to debug them with kgdb over the 
> serial console. Well, today I tried for the n-th time again and after rc2-mm3 
> blocked again while loading, here's what I did:
> 
> <snip>
> [   12.335438] NET: Registered protocol family 17
> [   12.362483] Testing NMI watchdog ... OK.
> [   12.416195] Starting balanced_irq
> [   12.443099] VFS: Mounted root (ext2 filesystem) readonly.
> [   12.472490] Freeing unused kernel memory: 196k freed
> [   12.521004] logips2pp: Detected unknown logitech mouse model 1
> [   12.572581] Warning: unable to open an initial console.
> [   12.972518] input: PS/2 Logitech Mouse on isa0060/serio1
> 
> Program received signal SIGTRAP, Trace/breakpoint trap.
> 0xc0102ee7 in resume_kernelX () at atomic.h:175 <--- this one is wrong for a 
> mysterious reason
> 175     {
> (gdb) p $eip
> $1 = (void *) 0xc0102ee7
> 
> (gdb) disas 0xc0102ee7
> Dump of assembler code for function resume_kernelX:
> 0xc0102ee7 <resume_kernelX+0>:  mov    0x30(%esp),%eax
> 0xc0102eeb <resume_kernelX+4>:  mov    0x38(%esp),%ah
> 0xc0102eef <resume_kernelX+8>:  mov    0x2c(%esp),%al
> 0xc0102ef3 <resume_kernelX+12>: and    $0x20403,%eax
> 0xc0102ef8 <resume_kernelX+17>: cmp    $0x403,%eax
> 0xc0102efd <resume_kernelX+22>: je     0xc0102f0c <ldt_ss>
> End of assembler dump.
> (gdb)  
> 
> And as we see, we're at the "mov    0x30(%esp),%eax" which accesses above the 
> bottom of the stack. After applying nmi_stack_correct-fix.patch, rc2-mm3 
> booted just fine, so I IMHO think that we might still be needing this, after 
> all.

Interesting.  It could be an interaction between the kgdb patch and the new
vm86 checking code.  (looks.  I don't think that's the case).

Stas, could you please take a look at 2.6.12-rc2-mm3's entry.S sometime,
see if you think my theory is correct?

It seems that you have CONFIG_TRAP_BAD_SYSCALL_EXITS enabled - I can't say
that I've ever used that, and I really should remove it.  But I doubt if
that is the cause of this bug.


The above code is accessing esp+56, but Stas's patch only offsets the stack
pointer by 32 bytes, so I assume this, in copy_thread():

-	p->thread.esp0 = (unsigned long) (childregs+1) - 8;
+	p->thread.esp0 = (unsigned long) (childregs+1) - 15;

fixes it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/