Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261965AbVDKWSU (ORCPT ); Mon, 11 Apr 2005 18:18:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261968AbVDKWRF (ORCPT ); Mon, 11 Apr 2005 18:17:05 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:33298 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S261965AbVDKWPg (ORCPT ); Mon, 11 Apr 2005 18:15:36 -0400 From: Russell King To: Andrew Morton CC: LKML Subject: [PATCH] Add comment about dma_supported() X-Patch-Ref: 01-fixes/05-dma_supported-comments Message-Id: Date: Mon, 11 Apr 2005 23:15:30 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 26 The ARM dma_supported() is rather basic, and I don't think it takes into account everything that it should do (eg, whether the mask agrees with what we'd return for GFP_DMA allocations). Note this. Signed-off-by: Russell King diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x '*.orig' -x '*.rej' -r orig/include/asm-arm/dma-mapping.h linux/include/asm-arm/dma-mapping.h --- orig/include/asm-arm/dma-mapping.h Wed Jan 12 10:13:19 2005 +++ linux/include/asm-arm/dma-mapping.h Fri Jun 18 17:56:02 2004 @@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr, * properly. For example, if your device can only drive the low 24-bits * during bus mastering, then you would pass 0x00ffffff as the mask * to this function. + * + * FIXME: This should really be a platform specific issue - we should + * return false if GFP_DMA allocations may not satisfy the supplied 'mask'. */ static inline int dma_supported(struct device *dev, u64 mask) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/