Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262016AbVDLGiB (ORCPT ); Tue, 12 Apr 2005 02:38:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262017AbVDLGiB (ORCPT ); Tue, 12 Apr 2005 02:38:01 -0400 Received: from waste.org ([216.27.176.166]:35787 "EHLO waste.org") by vger.kernel.org with ESMTP id S262016AbVDLGhy (ORCPT ); Tue, 12 Apr 2005 02:37:54 -0400 Date: Mon, 11 Apr 2005 23:37:45 -0700 From: Matt Mackall To: Jesper Juhl Cc: Steven French , Steve French , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] cifs: md5 cleanup - functions Message-ID: <20050412063745.GN25554@waste.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 22 On Mon, Apr 11, 2005 at 10:11:39PM +0200, Jesper Juhl wrote: > > Function names and return types on same line - conform to established > fs/cifs/ style. > > Patch is also available at: > http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_md5-funct.patch I think the right thing to do here is what I did with the SHA1 code from random.c: put the favorite implementation in lib/ and replace the cryptoapi and CIFS implementations (and any other users) with it. If you feel like tackling this, let me know, it's been on my todo list for a while. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/