Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262096AbVDLKVU (ORCPT ); Tue, 12 Apr 2005 06:21:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262101AbVDLKVU (ORCPT ); Tue, 12 Apr 2005 06:21:20 -0400 Received: from fire.osdl.org ([65.172.181.4]:20677 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S262096AbVDLKVS (ORCPT ); Tue, 12 Apr 2005 06:21:18 -0400 Date: Tue, 12 Apr 2005 03:21:08 -0700 From: Andrew Morton To: jes@trained-monkey.org (Jes Sorensen) Cc: linux-kernel@vger.kernel.org Subject: Re: [patch] mspec driver for 2.6.12-rc2-mm3 Message-Id: <20050412032108.0fa90169.akpm@osdl.org> In-Reply-To: <16987.39773.267117.925489@jaguar.mkp.net> References: <16987.39773.267117.925489@jaguar.mkp.net> X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 492 Lines: 13 jes@trained-monkey.org (Jes Sorensen) wrote: > > + if (atomic_dec(&vdata->refcnt) == 0) { atomic_dec() normally returns void. ia64's returns int, which is a bit risky for cross-arch developemnt. atomic_dec_and_test() would be more conventional. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/