Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262421AbVDLNb0 (ORCPT ); Tue, 12 Apr 2005 09:31:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262453AbVDLM7u (ORCPT ); Tue, 12 Apr 2005 08:59:50 -0400 Received: from fmr17.intel.com ([134.134.136.16]:45741 "EHLO orsfmr002.jf.intel.com") by vger.kernel.org with ESMTP id S262421AbVDLMwK (ORCPT ); Tue, 12 Apr 2005 08:52:10 -0400 Subject: Re: [PATCH 5/6]physical CPU hot add From: Li Shaohua To: Zwane Mwaikambo Cc: lkml , ACPI-DEV , Len Brown , Pavel Machek , Andrew Morton In-Reply-To: References: <1113283863.27646.432.camel@sli10-desk.sh.intel.com> Content-Type: text/plain Message-Id: <1113310145.5155.12.camel@sli10-desk.sh.intel.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Tue, 12 Apr 2005 20:49:05 +0800 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 23 On Tue, 2005-04-12 at 20:17, Zwane Mwaikambo wrote: > On Tue, 12 Apr 2005, Li Shaohua wrote: > > > #ifdef CONFIG_HOTPLUG_CPU > > +int __attribute__ ((weak)) smp_prepare_cpu(int cpu) > > +{ > > + return 0; > > +} > > + > > Any way for you to avoid using weak attribute? Just want to avoid more 'ifdef' or 'define empty routine for other archs' staffs. Someone prefer 'weak' attribute. Either way is ok to me, but if you think the former is better, I'd change it. Thanks, Shaohua - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/