Date: Tue, 12 Apr 2005 17:50:34 +0100
From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix floppy disk dependencies
Message-ID: <20050412165034.GN8859@parcelfarce.linux.theplanet.co.uk>
References: <E1DL7Bg-0003C9-Vj@raistlin.arm.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1DL7Bg-0003C9-Vj@raistlin.arm.linux.org.uk>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 920
Lines: 27

On Mon, Apr 11, 2005 at 11:15:20PM +0100, Russell King wrote:
> Both the RiscPC and (optionally) EBSA285 have floppy disk
> support.  Allow this option to be selected on these ARM
> platforms again.

I think it's a wrong approach.  Instead of this collection of
dependencies we should bite the bullet and put

config HAS_GENERIC_FDC
	bool
	default y

in arch/*/Kconfig of platforms that do have it and

config BLK_DEV_FD
	tristate "Normal floppy disk support"
        depends on HAS_GENERIC_FDC

in drivers/block/Kconfig.  That way we can express such dependencies
sanely without bringing all the gory details in one pile.

I'll do that unless there are serious objections...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/