Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262139AbVDMBF0 (ORCPT ); Tue, 12 Apr 2005 21:05:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262873AbVDMBDF (ORCPT ); Tue, 12 Apr 2005 21:03:05 -0400 Received: from smtp205.mail.sc5.yahoo.com ([216.136.129.95]:62393 "HELO smtp205.mail.sc5.yahoo.com") by vger.kernel.org with SMTP id S262141AbVDMBCd (ORCPT ); Tue, 12 Apr 2005 21:02:33 -0400 Message-ID: <425C6F98.7060705@yahoo.com.au> Date: Wed, 13 Apr 2005 11:02:16 +1000 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050324 Debian/1.7.6-1 X-Accept-Language: en MIME-Version: 1.0 To: Andrew Morton CC: axboe@suse.de, linux-kernel@vger.kernel.org, kenneth.w.chen@intel.com, Manfred Spraul Subject: Re: [patch 1/9] GFP_ZERO fix References: <425BC262.1070500@yahoo.com.au> <425BC387.3080703@yahoo.com.au> <20050412124741.366caee3.akpm@osdl.org> In-Reply-To: <20050412124741.366caee3.akpm@osdl.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 25 Andrew Morton wrote: > Nick Piggin wrote: > >> #define GFP_LEVEL_MASK (__GFP_WAIT|__GFP_HIGH|__GFP_IO|__GFP_FS| \ >> - __GFP_COLD|__GFP_NOWARN|__GFP_REPEAT| \ >> - __GFP_NOFAIL|__GFP_NORETRY|__GFP_NO_GROW|__GFP_COMP) >> + __GFP_COLD|__GFP_NOWARN|__GFP_REPEAT|__GFP_NOFAIL| \ >> + __GFP_NORETRY|__GFP_NO_GROW|__GFP_COMP|__GFP_ZERO) > > > Passing GFP_ZERO into kmem_cache_alloc() is such a bizarre thing to do, > perhaps a BUG is the correct response. > I just thought it was a bit cheeky given the comment right above it ;) -- SUSE Labs, Novell Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/