Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261360AbVDMO67 (ORCPT ); Wed, 13 Apr 2005 10:58:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261361AbVDMO67 (ORCPT ); Wed, 13 Apr 2005 10:58:59 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:30166 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261360AbVDMO6v (ORCPT ); Wed, 13 Apr 2005 10:58:51 -0400 Date: Wed, 13 Apr 2005 15:58:46 +0100 From: Christoph Hellwig To: "Bodo Eggert " <7eggert@gmx.de> Cc: Al Viro , Andrew Morton , linux-kernel@vger.kernel.org, Adrian Bunk Subject: Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use Message-ID: <20050413145846.GA10017@infradead.org> Mail-Followup-To: Christoph Hellwig , "Bodo Eggert " <7eggert@gmx.de>, Al Viro , Andrew Morton , linux-kernel@vger.kernel.org, Adrian Bunk References: <3SGgN-41r-1@gated-at.bofh.it> <3SGA8-4n3-9@gated-at.bofh.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 23 On Wed, Apr 13, 2005 at 12:40:38PM +0200, Bodo Eggert wrote: > If there are checks, they should be there for a purpose, emphasis here is on _should_ > and any sane reader will asume these checks to be nescensary. That's a bad assumptions when you're deadling with drivers or software of similar quality. > If they are dead code, you > can say that, but please don't flame Adrian for fixing obviously buggy code > in a way that is sane and at least more correct than the original without > using several days of his lifetime to analyze the whole driver. Instead, you > could provide the correct fix. The correct fix is to remove the check. And no, we don't have a rule that someone must provide something better when trying to critize it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/