Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261397AbVDQSU2 (ORCPT ); Sun, 17 Apr 2005 14:20:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261401AbVDQSU1 (ORCPT ); Sun, 17 Apr 2005 14:20:27 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:38673 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S261397AbVDQSTu (ORCPT ); Sun, 17 Apr 2005 14:19:50 -0400 Date: Sun, 17 Apr 2005 20:19:48 +0200 From: Adrian Bunk To: Alexey Dobriyan , Andrew Morton , Bjorn Helgaas , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, len.brown@intel.com, acpi-devel@lists.sourceforge.net, Herbert Xu Subject: [2.6 patch] ACPI: add two missing config.h #include's Message-ID: <20050417181948.GB3625@stusta.de> References: <20050415151053.GM5456@stusta.de> <20050416023852.GI4831@stusta.de> <20050416085923.A10826@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050416085923.A10826@flint.arm.linux.org.uk> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1876 Lines: 63 On Sat, Apr 16, 2005 at 08:59:23AM +0100, Russell King wrote: > On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote: > > In the Linux kernel, it's more common to put such header dependencies > > for header files into the C files, but if the ACPI people agree a patch > > to add the #include to acpi_bus.h is the other possble > > correct solution for this issue. > > With the exception of linux/config.h. > > Do a 'make configcheck' and it'll tell you where linux/config.h is missing > and where it shouldn't be. OK, then the patch below is the correct solution. cu Adrian <-- snip --> This patch fixes the following warning by adding two missing config.h #include's: <-- snip --> ... CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' ... <-- snip --> Signed-off-by: Adrian Bunk --- linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h.old 2005-04-17 19:05:23.000000000 +0200 +++ linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h 2005-04-17 19:05:37.000000000 +0200 @@ -26,6 +26,7 @@ #ifndef __ACPI_BUS_H__ #define __ACPI_BUS_H__ +#include #include #include --- linux-2.6.12-rc2-mm3-full/include/linux/acpi.h.old 2005-04-17 19:25:51.000000000 +0200 +++ linux-2.6.12-rc2-mm3-full/include/linux/acpi.h 2005-04-17 19:24:54.000000000 +0200 @@ -25,6 +25,8 @@ #ifndef _LINUX_ACPI_H #define _LINUX_ACPI_H +#include + #ifdef CONFIG_ACPI #ifndef _LINUX - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/