Message-ID: <4263AC46.5010703@in.ibm.com>
Date: Mon, 18 Apr 2005 18:17:02 +0530
From: Hariprasad Nellitheertha <hari@in.ibm.com>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: Andi Kleen <ak@muc.de>
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][x86_64] Introducing the memmap= kernel command line option
References: <425F5BA3.3050001@in.ibm.com> <20050415173040.GK50241@muc.de>
In-Reply-To: <20050415173040.GK50241@muc.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1121
Lines: 41

Andi Kleen wrote:
> On Fri, Apr 15, 2005 at 11:43:55AM +0530, Hariprasad Nellitheertha wrote:
> 
>>Hi Andi,
>>
>>In order to port kdump to x86_64, we need to have the 
>>memmap= kernel command line option available. This is so 
>>that the dump-capture kernel can be booted with a custom 
>>memory map.
>>
>>The attached patch adds the memmap= functionality to the 
>>x86_64 kernel. It is against 2.6.12-rc2-mm3. I have done 
>>some amount of testing and it is working fine.
>>
>>Could you kindly review this patch and let me know your 
>>thoughts on it.
> 
> 
> You should add a __setup somewhere, otherwise the kernel
> will complain about unknown arguments or generate a memmap
> variable in inits environment. 

Sure. Will add that.

> 
> Comma parsing would be nice.

Will add this for i386 as well and send out another patch

> 
> Otherwise it looks ok.

Thanks!

- Hari

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/