Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261384AbVDSHzj (ORCPT ); Tue, 19 Apr 2005 03:55:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261386AbVDSHzj (ORCPT ); Tue, 19 Apr 2005 03:55:39 -0400 Received: from hirsch.in-berlin.de ([192.109.42.6]:36064 "EHLO hirsch.in-berlin.de") by vger.kernel.org with ESMTP id S261384AbVDSHzg (ORCPT ); Tue, 19 Apr 2005 03:55:36 -0400 X-Envelope-From: kraxel@bytesex.org Date: Tue, 19 Apr 2005 09:53:48 +0200 From: Gerd Knorr To: Adrian Bunk Cc: 2003 John Klar , linux-kernel@vger.kernel.org, video4linux-list@redhat.com Subject: Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups Message-ID: <20050419075348.GD15656@bytesex> References: <20050419005315.GP5489@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050419005315.GP5489@stusta.de> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 516 Lines: 13 > - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump That's a debug helper function, please don't drop it. #if 0 might be ok, not sure though, the tveeprom module is also used by a out-of-kernel driver (ivtv). Otherwise the patch looks fine to me. Gerd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/