Date: Tue, 19 Apr 2005 11:30:44 -0700
From: "David S. Miller" <davem@davemloft.net>
To: Martin Hicks <mort@sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, holt@sgi.com
Subject: Re: [PATCH] pgtables: fix GFP_KERNEL allocation with preempt
 disabled
Message-Id: <20050419113044.26911ebf.davem@davemloft.net>
In-Reply-To: <20050419170413.GB21616@localhost>
References: <20050419170413.GB21616@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 875
Lines: 26

On Tue, 19 Apr 2005 13:04:13 -0400
Martin Hicks <mort@sgi.com> wrote:

> This is a fix to the pgtable_quicklist code.  There is a GFP_KERNEL
> allocation in pgtable_quicklist_alloc(), which spews the usual warnings
> if the kernel is under heavy VM pressure and the reclaim code is
> invoked.
> 
> This patch is against 2.6.12-rc2-mm2

I think you should really drop the preempt disable during this allocation
instead, that's what we do in the sparc64 quicklist code.

It's very simple, change the code to:

		preempt_enable();
	} else {
		preempt_enable();
		ret = (unsigned long *) ...;
	}
	/* preempt_enable() no longer here */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/