Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261612AbVDSTQi (ORCPT ); Tue, 19 Apr 2005 15:16:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261596AbVDSTQi (ORCPT ); Tue, 19 Apr 2005 15:16:38 -0400 Received: from witte.sonytel.be ([80.88.33.193]:24962 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S261612AbVDSTQK (ORCPT ); Tue, 19 Apr 2005 15:16:10 -0400 Date: Tue, 19 Apr 2005 21:15:41 +0200 (CEST) From: Geert Uytterhoeven To: Denis Vlasenko cc: Linux Kernel Development , Matt Mackall Subject: Re: [PATCH] introduce generic 64bit rotations and i386 asm optimized version In-Reply-To: <200504190918.10279.vda@port.imtp.ilyichevsk.odessa.ua> Message-ID: References: <200504190918.10279.vda@port.imtp.ilyichevsk.odessa.ua> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 947 Lines: 30 On Tue, 19 Apr 2005, Denis Vlasenko wrote: [ Please inline patches, so it's easier to comment on them ] > +static inline u64 rol64(u64 x,int num) { ^^^ > + if(__builtin_constant_p(num)) > + return constant_rol64(x,num); > + /* Hmmm... shall we do cnt&=63 here? */ ^^^ num? > + return ((x<>(64-num))); > +} Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/