DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=oi3R+X/RMdh3GTOUYKH9Tdbxl1DqP6PaVOWS76QivpdSQljKVVEhsZHdg7YCOGqh6U2A0snwySTjBByrn2Lj7adoHKUoscGwMmClTcRoPdyQXtFNhFGvDZiQ0smURJ/vKB6mAZzIr85yzEXEejmA0OJ9EmhZy96scL8GRKse6HY=
Message-ID: <84144f0205042023366dc0b16@mail.gmail.com>
Date: Thu, 21 Apr 2005 09:36:18 +0300
From: Pekka Enberg <penberg@gmail.com>
Reply-To: Pekka Enberg <penberg@gmail.com>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Subject: Re: [PATCH] remove some usesless casts
Cc: =?ISO-8859-1?Q?J=F6rn_Engel?= <joern@wohnheim.fh-wedel.de>,
       linux-kernel@vger.kernel.org, penberg@cs.helsinki.fi
In-Reply-To: <4266C0C3.7070002@lougher.demon.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
References: <20050420065500.GA24213@wohnheim.fh-wedel.de>
	 <4266732A.6050508@lougher.demon.co.uk>
	 <20050420213336.GA22421@wohnheim.fh-wedel.de>
	 <4266C0C3.7070002@lougher.demon.co.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1051
Lines: 24

Phillip,

J?rn Engel wrote:
> > Your definition of _unnecessary_ casts may differ from mine.
> > Basically, every cast is unnecessary, except for maybe one or two - if
> > that many.

On 4/20/05, Phillip Lougher <phillip@lougher.demon.co.uk> wrote:
> Well we agree to differ then.  In my experience casts are sometimes
> necessary, and are often less clumsy than the alternatives (such as
> unions).  This is probably a generational thing, the fashion today is to
> make languages much more strongly typechecked than before.

I think J?rn means that if you need an opaque data type, use void
pointers (which are automatically cast to the proper type) and that
all other casts are a design smell (except for the one or two special
cases where you actually need them).

                                 Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/