Date: Thu, 21 Apr 2005 09:32:48 -0700
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Ed L Cashin <ecashin@coraid.com>
Cc: greg@kroah.com, 7eggert@gmx.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces
 configuration
Message-Id: <20050421093248.2061fb1a.rddunlap@osdl.org>
In-Reply-To: <87pswoi1vl.fsf@coraid.com>
References: <3VqSf-2z7-15@gated-at.bofh.it>
	<E1DOVtj-0003bF-6c@be1.7eggert.dyndns.org>
	<87y8bcjlpq.fsf@coraid.com>
	<20050421145658.GA27263@kroah.com>
	<87pswoi1vl.fsf@coraid.com>
Organization: OSDL
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1673
Lines: 45

On Thu, 21 Apr 2005 11:30:06 -0400 Ed L Cashin wrote:

| Greg KH <greg@kroah.com> writes:
| 
| > On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote:
| >> "Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>" <7eggert@gmx.de> writes:
| >> 
| >> > Ed L Cashin <ecashin@coraid.com> wrote:
| >> >
| >> >> +++ b/Documentation/aoe/aoe.txt       2005-04-20 11:42:20.000000000 -0400
| >> >
| >> >> +  When the aoe driver is a module, use
| >> >
| >> > Is there any reason for this inconsistent behaviour?
| >> 
| >> Yes, the /sys/module/aoe area is only present when the aoe driver is a
| >> module.
| >
| > Not true, have you looked in /sys/module lately?  :)
| >
| >> It would be nicer if there were a sysfs area where I could
| >> put this file regardless of whether the driver is a module or built
| >> into the kernel.  
| >
| > That's the place for it.  It will be there if the driver is built as a
| > module or into the kernel.
| 
| Wow!  Well, that's very convenient for driver writers, so I'm pleased,
| and I can update the docs.  It surprises me, though, to find out that
| /sys/module is for things other than modules.

Just depends on your definition of a module.

AOE (or just about any device driver) can be considered logically
as a module.  You seem to be equating module with "loadable module"
vs. a builtin module.  The good news is that /sys/module works
for loadable or builtin modules.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/