Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261875AbVDUUyr (ORCPT ); Thu, 21 Apr 2005 16:54:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261876AbVDUUyr (ORCPT ); Thu, 21 Apr 2005 16:54:47 -0400 Received: from coderock.org ([193.77.147.115]:29864 "EHLO trashy.coderock.org") by vger.kernel.org with ESMTP id S261875AbVDUUyd (ORCPT ); Thu, 21 Apr 2005 16:54:33 -0400 Date: Thu, 21 Apr 2005 22:54:25 +0200 From: Domen Puncer To: Ed L Cashin Cc: 7eggert@gmx.de, linux-kernel@vger.kernel.org, Greg K-H Subject: Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration Message-ID: <20050421205425.GA14686@nd47.coderock.org> References: <3VqSf-2z7-15@gated-at.bofh.it> <87y8bcjlpq.fsf@coraid.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y8bcjlpq.fsf@coraid.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 26 On 21/04/05 09:36 -0400, Ed L Cashin wrote: > "Bodo Eggert " <7eggert@gmx.de> writes: > > > Ed L Cashin wrote: > > ... > >> + /sys/module/aoe/parameters/aoe_iflist instead of > > ^^^ > > > > Why does the module name need to be part of the attribute? > > That's redundant. That's redundant. > > Yes. That's true. Redundancy isn't always bad, though, and using the > "aoe_" prefix lets the kernel parameter for the built-in aoe driver be > the same as the parameter for the modular driver. The __setup() stuff is redundancy too, as module parameters already work as boot parameters (ie. aoe.iflist). Domen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/