Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262617AbVDYOcS (ORCPT ); Mon, 25 Apr 2005 10:32:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262619AbVDYOcS (ORCPT ); Mon, 25 Apr 2005 10:32:18 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:11676 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S262617AbVDYOcP (ORCPT ); Mon, 25 Apr 2005 10:32:15 -0400 Date: Mon, 25 Apr 2005 15:32:11 +0100 From: Christoph Hellwig To: Jes Sorensen Cc: Christoph Hellwig , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [patch] mspec driver for 2.6.12-rc2-mm3 Message-ID: <20050425143211.GA9902@infradead.org> Mail-Followup-To: Christoph Hellwig , Jes Sorensen , Andrew Morton , linux-kernel@vger.kernel.org References: <16987.39773.267117.925489@jaguar.mkp.net> <20050412032747.51c0c514.akpm@osdl.org> <20050413204335.GA17012@infradead.org> <20050424101615.GA22393@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 20 On Mon, Apr 25, 2005 at 06:13:01AM -0400, Jes Sorensen wrote: > >>>>> "Christoph" == Christoph Hellwig writes: > > >> The code use the size to calculate, it could be changed either > >> way, don't think it's worth making the change. > > Christoph> The current code is obsufcated, see the pages-1 stuff and > Christoph> co. Please change it. > > Both ways work, this is down to nitpicking for the sake of > nitpicking. Whatever, I'll change it. It's nitpicking to keep the code readable. Same thing as always using named initializers for method vectors or similar things. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/