Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262664AbVDYP4N (ORCPT ); Mon, 25 Apr 2005 11:56:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262663AbVDYPzv (ORCPT ); Mon, 25 Apr 2005 11:55:51 -0400 Received: from fire.osdl.org ([65.172.181.4]:12959 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S262668AbVDYPxt (ORCPT ); Mon, 25 Apr 2005 11:53:49 -0400 Date: Mon, 25 Apr 2005 08:55:22 -0700 (PDT) From: Linus Torvalds To: Andi Kleen , Roland McGrath cc: Andrew Morton , Kernel Mailing List Subject: Re: [PATCH] x86_64: handle iret faults better In-Reply-To: <20050425153310.GB16828@wotan.suse.de> Message-ID: References: <200504240050.j3O0obqR032684@magilla.sf.frob.com> <20050425153310.GB16828@wotan.suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 618 Lines: 24 On Mon, 25 Apr 2005, Andi Kleen wrote: > > But I really hate your is_iret hack in traps.c. I agree. Why don't you just do pushl $0 pushl $do_iret_error jmp error_code And just have a "do_iret_error()" handler in traps.c which does the right thing? That seems like the _sane_ thing to do, and that way there is never any confusion about what is going on. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/