Subject: Re: [patch 1/1] uml: fix handling of no fpx_regs [critical, for
	2.6.12]
From: Alexander Nyberg <alexn@dsv.su.se>
To: blaisorblade@yahoo.it
Cc: akpm@osdl.org, jdike@addtoit.com, bstroesser@fujitsu-siemens.com,
       linux-kernel@vger.kernel.org,
       user-mode-linux-devel@lists.sourceforge.net, aleidenf@bigpond.net.au
In-Reply-To: <20050425191253.B9FE045EBB@zion>
References: <20050425191253.B9FE045EBB@zion>
Content-Type: text/plain; charset=ISO-8859-1
Date: Mon, 25 Apr 2005 21:57:47 +0200
Message-Id: <1114459067.983.22.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1754
Lines: 46

m?n 2005-04-25 klockan 21:12 +0200 skrev blaisorblade@yahoo.it:
> From: Andree Leidenfrost <aleidenf@bigpond.net.au>, Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> 
> Fix the error path, which is triggered when the processor misses the fpx regs
> (i.e. the "fxsr" cpuinfo feature). For instance by VIA C3 Samuel2. Tested and
> obvious, please merge ASAP.
> 
> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> ---
> 
>  linux-2.6.12-paolo/arch/um/os-Linux/sys-i386/registers.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff -puN arch/um/os-Linux/sys-i386/registers.c~uml-fix-no_fpx_regs_handling arch/um/os-Linux/sys-i386/registers.c
> --- linux-2.6.12/arch/um/os-Linux/sys-i386/registers.c~uml-fix-no_fpx_regs_handling	2005-04-25 21:03:11.000000000 +0200
> +++ linux-2.6.12-paolo/arch/um/os-Linux/sys-i386/registers.c	2005-04-25 21:08:07.000000000 +0200
> @@ -105,14 +105,15 @@ void init_registers(int pid)
>  		panic("check_ptrace : PTRACE_GETREGS failed, errno = %d",
>  		      err);
>  
> +	errno = 0;
>  	err = ptrace(PTRACE_GETFPXREGS, pid, 0, exec_fpx_regs);
>  	if(!err)
>  		return;
> +	if(errno != EIO)
> +		panic("check_ptrace : PTRACE_GETFPXREGS failed, errno = %d",
> +		      errno);

Looks like you mean "if (err != EIO)" here


>  	have_fpx_regs = 0;
> -	if(err != EIO)
> -		panic("check_ptrace : PTRACE_GETFPXREGS failed, errno = %d",
> -		      err);
>  
>  	err = ptrace(PTRACE_GETFPREGS, pid, 0, exec_fp_regs);
>  	if(err)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/