Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262790AbVDYUPh (ORCPT ); Mon, 25 Apr 2005 16:15:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262789AbVDYUPg (ORCPT ); Mon, 25 Apr 2005 16:15:36 -0400 Received: from mail.kroah.org ([69.55.234.183]:43713 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262773AbVDYUNR (ORCPT ); Mon, 25 Apr 2005 16:13:17 -0400 Date: Mon, 25 Apr 2005 13:12:50 -0700 From: Greg KH To: Alexander Nyberg Cc: Amit Gud , Alan Stern , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, akpm@osdl.org, jgarzik@pobox.com, cramerj@intel.com, USB development list Subject: Re: [PATCH] PCI: Add pci shutdown ability Message-ID: <20050425201250.GB24433@kroah.com> References: <20050425182951.GA23209@kroah.com> <20050425185113.GC23209@kroah.com> <20050425190606.GA23763@kroah.com> <1114458325.983.17.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1114458325.983.17.camel@localhost.localdomain> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1371 Lines: 33 On Mon, Apr 25, 2005 at 09:45:25PM +0200, Alexander Nyberg wrote: > > Well it seems that people are starting to want to hook the reboot > > notifier, or the device shutdown facility in order to properly shutdown > > pci drivers to make kexec work nicer. > > > > So here's a patch for the PCI core that allows pci drivers to now just > > add a "shutdown" notifier function that will be called when the system > > is being shutdown. It happens just after the reboot notifier happens, > > and it should happen in the proper device tree order, so everyone should > > be happy. > > > > Any objections to this patch? > > Not sure what you mean by "make kexec work nicer" but if it is because > some devices don't work after a kexec I have some objections. > What about the kexec-on-panic? People are starting to submit patches for pci drivers that add "reboot notifier" hooks, under the guise of fixing up kexec issues with those drivers. That is why I proposed this patch, to make it easier for such drivers to shutdown properly, without needing a reboot notifier hook (which takes up more code and memory. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/