Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261168AbVDYU20 (ORCPT ); Mon, 25 Apr 2005 16:28:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261163AbVDYU2Y (ORCPT ); Mon, 25 Apr 2005 16:28:24 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:26552 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S261162AbVDYU03 (ORCPT ); Mon, 25 Apr 2005 16:26:29 -0400 Date: Mon, 25 Apr 2005 22:26:26 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Colin Leroy cc: "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH] hfsplus: don't oops on bad FS In-Reply-To: <20050425220345.6b2ed6d5@jack.colino.net> Message-ID: References: <20050425211915.126ddab5@jack.colino.net> <20050425220345.6b2ed6d5@jack.colino.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 20 Hi, On Mon, 25 Apr 2005, Colin Leroy wrote: > > Actually it looks like we are always leaking it, so actually > > hfsplus_put_super() needs fixing, could you add the check and kfree > > there and do the same fix for hfs? > > Mmh, right. Here's an updated version that fixes it too. Don't change hfsplus_fill_super, add a "if (!sb->s_fs_info) return;" to hfsplus_put_super (and also hfs_put_super, so you can kill kfree from hfs_fill_super). bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/