Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261183AbVDYU7d (ORCPT ); Mon, 25 Apr 2005 16:59:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261185AbVDYU7d (ORCPT ); Mon, 25 Apr 2005 16:59:33 -0400 Received: from HELIOUS.MIT.EDU ([18.248.3.87]:1194 "EHLO neo.rr.com") by vger.kernel.org with ESMTP id S261183AbVDYU71 (ORCPT ); Mon, 25 Apr 2005 16:59:27 -0400 Date: Mon, 25 Apr 2005 16:55:36 -0400 From: Adam Belay To: Pavel Machek Cc: Greg KH , Amit Gud , Alan Stern , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, akpm@osdl.org, jgarzik@pobox.com, cramerj@intel.com, USB development list Subject: Re: [PATCH] PCI: Add pci shutdown ability Message-ID: <20050425205536.GF27771@neo.rr.com> Mail-Followup-To: Adam Belay , Pavel Machek , Greg KH , Amit Gud , Alan Stern , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, akpm@osdl.org, jgarzik@pobox.com, cramerj@intel.com, USB development list References: <20050425182951.GA23209@kroah.com> <20050425185113.GC23209@kroah.com> <20050425190606.GA23763@kroah.com> <20050425204207.GA23724@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050425204207.GA23724@elf.ucw.cz> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1640 Lines: 41 On Mon, Apr 25, 2005 at 10:42:07PM +0200, Pavel Machek wrote: > Hi! > > > Well it seems that people are starting to want to hook the reboot > > notifier, or the device shutdown facility in order to properly shutdown > > pci drivers to make kexec work nicer. > > > > So here's a patch for the PCI core that allows pci drivers to now just > > add a "shutdown" notifier function that will be called when the system > > is being shutdown. It happens just after the reboot notifier happens, > > and it should happen in the proper device tree order, so everyone should > > be happy. > > > > Any objections to this patch? > > Yes. > > I believe it should just do suspend(PMSG_SUSPEND) before system > shutdown. If you think distintion between shutdown and suspend is > important (I am not 100% convinced it is), we can just add flag > saying "this is system shutdown". So if I understand this correctly, you'd like to manually turn off devices during a power off. I believe the ACPI spec recommends this for S4 (but also to leave on wake devices), but not necessarily S5. Still it may be a good idea. Comments? > > Actually this patch should be in the queue somewhere... We had it in > suse trees for a long time, and IMO it can solve problem easily. Yeah, that's what I had in mind when I mentioned PMSG_FREEZE. It seems to replace "shutdown" in many ways, is this correct? Thanks, Adam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/