Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261213AbVDYVaT (ORCPT ); Mon, 25 Apr 2005 17:30:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261202AbVDYVaS (ORCPT ); Mon, 25 Apr 2005 17:30:18 -0400 Received: from smtp.istop.com ([66.11.167.126]:16297 "EHLO smtp.istop.com") by vger.kernel.org with ESMTP id S261226AbVDYV1w (ORCPT ); Mon, 25 Apr 2005 17:27:52 -0400 From: Daniel Phillips To: Jesper Juhl Subject: Re: [PATCH 5/7] dlm: device interface Date: Mon, 25 Apr 2005 17:27:58 -0400 User-Agent: KMail/1.7 Cc: David Teigland , linux-kernel@vger.kernel.org, akpm@osdl.org References: <20050425151303.GF6826@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200504251727.58644.phillips@istop.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 21 On Monday 25 April 2005 12:09, Jesper Juhl wrote: > On Mon, 25 Apr 2005, David Teigland wrote: > > +/* Close on control device */ > > +static int dlm_ctl_close(struct inode *inode, struct file *file) > > +{ > > + return 0; > > +} > > return void? and what's the purpose of this function? seems silly to me to > have a function that does nothing but return 0 ever. How about just adding "inline" calling it "documentation"? Regards, Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/