Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261216AbVDYVeT (ORCPT ); Mon, 25 Apr 2005 17:34:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261224AbVDYVa7 (ORCPT ); Mon, 25 Apr 2005 17:30:59 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:465 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S261201AbVDYVSv (ORCPT ); Mon, 25 Apr 2005 17:18:51 -0400 Date: Mon, 25 Apr 2005 23:13:53 +0200 From: Pavel Machek To: Greg KH Cc: Amit Gud , Alan Stern , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, akpm@osdl.org, jgarzik@pobox.com, cramerj@intel.com, USB development list Subject: Re: [PATCH] PCI: Add pci shutdown ability Message-ID: <20050425211353.GF3906@elf.ucw.cz> References: <20050425182951.GA23209@kroah.com> <20050425185113.GC23209@kroah.com> <20050425190606.GA23763@kroah.com> <20050425204207.GA23724@elf.ucw.cz> <20050425210014.GA25247@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050425210014.GA25247@kroah.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 34 Hi! > > > Well it seems that people are starting to want to hook the reboot > > > notifier, or the device shutdown facility in order to properly shutdown > > > pci drivers to make kexec work nicer. > > > > > > So here's a patch for the PCI core that allows pci drivers to now just > > > add a "shutdown" notifier function that will be called when the system > > > is being shutdown. It happens just after the reboot notifier happens, > > > and it should happen in the proper device tree order, so everyone should > > > be happy. > > > > > > Any objections to this patch? > > > > Yes. > > > > I believe it should just do suspend(PMSG_SUSPEND) before system > > shutdown. If you think distintion between shutdown and suspend is > > important (I am not 100% convinced it is), we can just add flag > > saying "this is system shutdown". > > Then why even have the device_shutdown() call and notifier in the struct > device_driver? Yes, I guess it is redundant. Perhaps it should be removed... Pavel -- Boycott Kodak -- for their patent abuse against Java. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/