Date: Mon, 25 Apr 2005 23:47:16 +0200 (CEST)
From: Jesper Juhl <juhl-lkml@dif.dk>
To: john stultz <johnstul@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>,
       Andi Kleen <ak@suse.de>, vojtech@suse.cz,
       Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Subject: Re: [PATCH] i386: fix hpet for systems that don't support legacy
 replacement  (v. A0)
In-Reply-To: <1114463827.18098.22.camel@cog.beaverton.ibm.com>
Message-ID: <Pine.LNX.4.62.0504252345500.2941@dragon.hyggekrogen.localhost>
References: <1114117417.19541.239.camel@cog.beaverton.ibm.com>
 <1114463827.18098.22.camel@cog.beaverton.ibm.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1162
Lines: 33

On Mon, 25 Apr 2005, john stultz wrote:

> Andrew,
> 	Currently the i386 HPET code assumes the entire HPET implementation
> from the spec is present. This breaks on boxes that do not implement the
> optional legacy timer replacement functionality portion of the spec.
> 
> This patch, which is very similar to my x86-64 patch for the same issue,
> fixes the problem allowing i386 systems that cannot use the HPET for the
> timer interrupt and RTC to still use the HPET as a time source. I've
> tested this patch on a system systems without HPET, with HPET but
> without legacy timer replacement, as well as HPET with legacy timer
> replacement.
> 
> There has been no changes since this patch was sent out to lkml for
> review.
> 

Tiny, tiny nit : 

> -		if (is_hpet_enabled()){
> +		if (is_hpet_enabled() && hpet_use_timer){
                                                       ^^-- space here?


-- 
Jesper Juhl

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/