Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261270AbVDYW2R (ORCPT ); Mon, 25 Apr 2005 18:28:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261266AbVDYW2Q (ORCPT ); Mon, 25 Apr 2005 18:28:16 -0400 Received: from [80.71.243.242] ([80.71.243.242]:59526 "EHLO tau.rusteko.ru") by vger.kernel.org with ESMTP id S261260AbVDYW1s (ORCPT ); Mon, 25 Apr 2005 18:27:48 -0400 From: Nikita Danilov MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17005.28381.102652.36606@gargle.gargle.HOWL> Date: Tue, 26 Apr 2005 02:27:41 +0400 To: Daniel Phillips Cc: David Teigland , akpm@osdl.org, Linux Kernel Mailing List Subject: Re: [PATCH 1b/7] dlm: core locking In-Reply-To: <200504251644.21566.phillips@istop.com> References: <20050425165826.GB11938@redhat.com> <17005.14407.228930.83593@gargle.gargle.HOWL> <200504251644.21566.phillips@istop.com> X-Mailer: VM 7.17 under 21.5 (patch 17) "chayote" (+CVS-20040321) XEmacs Lucid Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 39 Daniel Phillips writes: > Hi Nikita, > > On Monday 25 April 2005 14:34, you wrote: > > > + > > > +static int is_remote(struct dlm_rsb *r) > > > +{ > > > + DLM_ASSERT(r->res_nodeid >= 0, dlm_print_rsb(r);); > > > + return r->res_nodeid ? TRUE : FALSE; > > > +} > > > > This can be simply > > > > return r->res_nodeid; > > Not quite the same. Perhaps you meant: > > return !!r->res_nodeid; Strictly speaking yes (assuming TRUE is defined as 1), but name is_remote() implies usages like if (is_remote(r)) { do_something(); } in such contexts !! is not necessary. > > Regards, > > Daniel Nikita. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/