Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261314AbVDZE25 (ORCPT ); Tue, 26 Apr 2005 00:28:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261345AbVDZE24 (ORCPT ); Tue, 26 Apr 2005 00:28:56 -0400 Received: from fmr18.intel.com ([134.134.136.17]:8679 "EHLO orsfmr003.jf.intel.com") by vger.kernel.org with ESMTP id S261314AbVDZE2A (ORCPT ); Tue, 26 Apr 2005 00:28:00 -0400 Subject: Re: [PATCH]broadcast IPI race condition on CPU hotplug From: Li Shaohua To: Zwane Mwaikambo Cc: lkml , Andrew Morton , Andi Kleen In-Reply-To: References: <1114482044.7068.17.camel@sli10-desk.sh.intel.com> Content-Type: text/plain Message-Id: <1114489490.7416.2.camel@sli10-desk.sh.intel.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Tue, 26 Apr 2005 12:24:50 +0800 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 24 Hi, On Tue, 2005-04-26 at 12:25, Zwane Mwaikambo wrote: > > > After a CPU is booted but before it's officially up (set online map, and > > enable interrupt), the CPU possibly will receive a broadcast IPI. After > > it's up, it will handle the stale interrupt soon and maybe cause oops if > > it's a smp-call-function-interrupt. This is quite possible in CPU > > hotplug case, but nearly can't occur at boot time. Below patch replaces > > broadcast IPI with send_ipi_mask just like the cluster mode. > > Ok, but isn't it sufficient to use send_ipi_mask in smp_call_function > instead? I'm not sure if other routines using broadcast IPI have this bug. Fixing the send_ipi_all API looks more generic. Is there any reason we should use broadcast IPI? Thanks, Shaohua - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/