Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261361AbVDZGrg (ORCPT ); Tue, 26 Apr 2005 02:47:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261355AbVDZGrf (ORCPT ); Tue, 26 Apr 2005 02:47:35 -0400 Received: from mail.kroah.org ([69.55.234.183]:38296 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261361AbVDZGrV (ORCPT ); Tue, 26 Apr 2005 02:47:21 -0400 Date: Mon, 25 Apr 2005 23:44:51 -0700 From: Greg KH To: Adam Belay , Benjamin Herrenschmidt , Pavel Machek , Amit Gud , Alan Stern , Linux Kernel list , linux-pci@atrey.karlin.mff.cuni.cz, Andrew Morton , Jeff Garzik , cramerj@intel.com, USB development list Subject: Re: [linux-usb-devel] Re: [PATCH] PCI: Add pci shutdown ability Message-ID: <20050426064450.GD5372@kroah.com> References: <20050425182951.GA23209@kroah.com> <20050425185113.GC23209@kroah.com> <20050425190606.GA23763@kroah.com> <20050425204207.GA23724@elf.ucw.cz> <1114486761.7183.14.camel@gaston> <20050426063328.GD3951@neo.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050426063328.GD3951@neo.rr.com> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 32 On Tue, Apr 26, 2005 at 02:33:28AM -0400, Adam Belay wrote: > On Tue, Apr 26, 2005 at 01:39:20PM +1000, Benjamin Herrenschmidt wrote: > > > > > I believe it should just do suspend(PMSG_SUSPEND) before system > > > shutdown. If you think distintion between shutdown and suspend is > > > important (I am not 100% convinced it is), we can just add flag > > > saying "this is system shutdown". > > > > > > Actually this patch should be in the queue somewhere... We had it in > > > suse trees for a long time, and IMO it can solve problem easily. > > > > I think we probably want a distinct state for shutdown ... > > Yes, it's possible we do. I'm not sure what every platform requires. The > question is should we make this change to pm_message_t in the short term? > "->shutdown", even though incorrect, seems to fill this role. > > Greg, have you seen shutdown methods doing anything special other than > standard "->suspend" stuff? Don't know, never looked. Try looking at the system and platform drivers, I think those are the only ones that have that callback hooked up right now. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/