Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261396AbVD0Kne (ORCPT ); Wed, 27 Apr 2005 06:43:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261398AbVD0KnT (ORCPT ); Wed, 27 Apr 2005 06:43:19 -0400 Received: from rev.193.226.232.93.euroweb.hu ([193.226.232.93]:55459 "EHLO dorka.pomaz.szeredi.hu") by vger.kernel.org with ESMTP id S261396AbVD0KnH (ORCPT ); Wed, 27 Apr 2005 06:43:07 -0400 To: pavel@suse.cz CC: hch@infradead.org, jamie@shareable.org, linuxram@us.ibm.com, 7eggert@gmx.de, bulb@ucw.cz, viro@parcelfarce.linux.theplanet.co.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@osdl.org In-reply-to: <20050427092450.GB1819@elf.ucw.cz> (message from Pavel Machek on Wed, 27 Apr 2005 11:24:50 +0200) Subject: Re: [PATCH] private mounts References: <20050426091921.GA29810@infradead.org> <20050426093628.GA30208@infradead.org> <20050426094727.GA30379@infradead.org> <20050426131943.GC2226@openzaurus.ucw.cz> <20050426201411.GA20109@elf.ucw.cz> <20050427092450.GB1819@elf.ucw.cz> Message-Id: From: Miklos Szeredi Date: Wed, 27 Apr 2005 12:42:04 +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 28 > > This is the controversial part in all it's glory: > > > > if (!(fc->flags & FUSE_ALLOW_OTHER) && current->fsuid != fc->user_id) > > return -EACCES; > > > > Leaving it out would gain us what exactly? > > Well, if it brings us ugly semantics, keeping those two lines out for > a while can help merge a lot... To the mount owner the semantics are quite normal. Others will be denied access to the mountpoint, which doesn't introduce any new semantics either. If you look at it from the POV of _any_ process, there are NO NEW SEMANTICS. Nothing that programs, scripts or anything has to be modified for. Nothing that could cause _any_ problems later, if this check was removed. Prove me wrong! Thanks, Miklos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/