Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261727AbVD0Pzk (ORCPT ); Wed, 27 Apr 2005 11:55:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261717AbVD0Pzj (ORCPT ); Wed, 27 Apr 2005 11:55:39 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:47827 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261700AbVD0Pza (ORCPT ); Wed, 27 Apr 2005 11:55:30 -0400 Date: Wed, 27 Apr 2005 16:55:26 +0100 From: Christoph Hellwig To: Jeff Garzik Cc: Jes Sorensen , Christoph Hellwig , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: returning non-ram via ->nopage, was Re: [patch] mspec driver for 2.6.12-rc2-mm3 Message-ID: <20050427155526.GA25921@infradead.org> Mail-Followup-To: Christoph Hellwig , Jeff Garzik , Jes Sorensen , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <16987.39773.267117.925489@jaguar.mkp.net> <20050412032747.51c0c514.akpm@osdl.org> <20050413204335.GA17012@infradead.org> <20050424101615.GA22393@infradead.org> <20050425144749.GA10093@infradead.org> <426FB56B.5000006@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <426FB56B.5000006@pobox.com> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 16 On Wed, Apr 27, 2005 at 11:53:15AM -0400, Jeff Garzik wrote: > I don't see anything wrong with a ->nopage approach. > > At Linus's suggestion, I used ->nopage in the implementation of > sound/oss/via82cxxx_audio.c. The difference is that you return kernel memory (actually pci_alloc_consistant memory that has it's own set of problems), while this is memory not in mem_map, so he allocates some regularly kernel memory too to have a struct page and just leaks it - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/