Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262180AbVD1Uoo (ORCPT ); Thu, 28 Apr 2005 16:44:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262117AbVD1Un2 (ORCPT ); Thu, 28 Apr 2005 16:43:28 -0400 Received: from piglet.wetlettuce.com ([82.68.149.69]:53002 "EHLO piglet.wetlettuce.com") by vger.kernel.org with ESMTP id S262159AbVD1UnF (ORCPT ); Thu, 28 Apr 2005 16:43:05 -0400 From: "Mark Broadbent" To: linux-kernel@vger.kernel.org To: jgarzik@pobox.com To: netdev@oss.sgi.com Subject: [PATCH] Tulip interrupt uses non IRQ safe spinlock Message-Id: Date: Thu, 28 Apr 2005 21:42:32 +0100 X-Wetlettuce-MailScanner: Mail is clear of Viree Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 35 The interrupt handling code in the tulip network driver appears to use a non IRQ safe spinlock in an interrupt context. The following patch should correct this. Signed-off-by: Mark Broadbent Index: linux-2.6.11/drivers/net/tulip/interrupt.c =================================================================== --- linux-2.6.11.orig/drivers/net/tulip/interrupt.c 2005-03-07 18:11:23.000000000 +0000 +++ linux-2.6.11/drivers/net/tulip/interrupt.c 2005-04-28 16:16:23.000000000 +0100 @@ -567,8 +567,9 @@ if (csr5 & (TxNoBuf | TxDied | TxIntr | TimerInt)) { unsigned int dirty_tx; + unsigned long flags; - spin_lock(&tp->lock); + spin_lock_irqsave(&tp->lock, flags); for (dirty_tx = tp->dirty_tx; tp->cur_tx - dirty_tx > 0; dirty_tx++) { @@ -640,7 +641,7 @@ dev->name, csr5, ioread32(ioaddr + CSR6), tp->csr6); tulip_restart_rxtx(tp); } - spin_unlock(&tp->lock); + spin_unlock_irqrestore(&tp->lock, flags); } /* Log errors. */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/