MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17009.33633.378204.859486@cargo.ozlabs.ibm.com>
Date: Fri, 29 Apr 2005 10:44:17 +1000
From: Paul Mackerras <paulus@samba.org>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] unify semaphore implementations
In-Reply-To: <20050428182926.GC16545@kvack.org>
References: <20050428182926.GC16545@kvack.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1174
Lines: 27

Benjamin LaHaise writes:

> Please review the following series of patches for unifying the 
> semaphore implementation across all architectures (not posted as 
> they're about 350K), as they have only been tested on x86-64.  The 
> code generated is functionally identical to the earlier i386 
> variant, but since gcc has no way of taking condition codes as 
> results, there are two additional instructions inserted from the 
> use of generic atomic operations.  All told the >6000 lines of code 
> deleted makes for a much easier job for subsequent patches changing 
> semaphore functionality.  Cheers,

Vetoed.

You have made semaphores bigger and slower on the architectures that
have load-linked/store-conditional instructions, which is at least
ppc, ppc64, sparc64 and alpha.  Did you take the trouble to understand
the ppc semaphore implementation?

What changes do you want to make to the semaphore functionality?

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/