Subject: Re: IDE problems with rmmod ide-cd
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jens Axboe <axboe@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <1114727044.18330.232.camel@localhost.localdomain>
References: <1114706653.18330.212.camel@localhost.localdomain>
	 <20050428172541.GN1876@suse.de>
	 <1114727044.18330.232.camel@localhost.localdomain>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1114783384.18355.283.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Fri, 29 Apr 2005 15:03:06 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 918
Lines: 22

On Iau, 2005-04-28 at 23:24, Alan Cox wrote:
> One possibility might be that the specific drive is incorrectly
> reporting capabilities and register_cdrom is setting cdi->exit as a
> result. Will try and work out what is going on there tomorrow.

Looks like a dumb bug in ide-cd. The error is coming from mrw_exit.

That gets called because ide-cd sets mask to 0 "I do everything" and
then subtracts features by checking drive bits. What it should do is set
the mask to every flag it knows about and then work back.

The ide-cd code doesn't know about CDC_MRW_W so its always a zero bit in
the mask, CDROM_CAN(CDC_MRW_W) is always true and cache flushes get
written.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/