Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262549AbVD3III (ORCPT ); Sat, 30 Apr 2005 04:08:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263141AbVD3III (ORCPT ); Sat, 30 Apr 2005 04:08:08 -0400 Received: from fep30-0.kolumbus.fi ([193.229.0.32]:30709 "EHLO fep30-app.kolumbus.fi") by vger.kernel.org with ESMTP id S262549AbVD3IIC (ORCPT ); Sat, 30 Apr 2005 04:08:02 -0400 Date: Sat, 30 Apr 2005 11:10:14 +0300 (EEST) From: Kai Makisara X-X-Sender: makisara@kai.makisara.local To: Greg KH cc: Greg KH , Alan Cox , James Bottomley , linux-scsi@vger.kernel.org, Linux Kernel Mailing List , stable@kernel.org, Justin Forbes , Zwane Mwaikambo , Cliff White , "Theodore Ts'o" , "Randy.Dunlap" , Chuck Wolber , torvalds@osdl.org, Andrew Morton Subject: Re: [06/07] [PATCH] SCSI tape security: require CAP_ADMIN for SG_IO etc. In-Reply-To: <20050430051030.GA10005@suse.de> Message-ID: References: <20050427171446.GA3195@kroah.com> <20050427171649.GG3195@kroah.com> <1114619928.18809.118.camel@localhost.localdomain> <1114694511.18809.187.camel@localhost.localdomain> <20050429042014.GC25474@kroah.com> <1114805784.18330.297.camel@localhost.localdomain> <20050429203805.GA2959@kroah.com> <20050430051030.GA10005@suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 30 On Fri, 29 Apr 2005, Greg KH wrote: > On Sat, Apr 30, 2005 at 08:52:31AM +0300, Kai Makisara wrote: > > On Fri, 29 Apr 2005, Greg KH wrote: > > ... > > > Switch it in both capable() calls in the patch? Kai, is this acceptable > > > to you also? > > > > > Yes. Using CAP_SYS_ADMIN here was wrong. > > Ok, care to send a new patch that I can use for the next -stable kernel > release? > Sent in a different message. This patch does not restrict usage of SCSI_IOCTL_START_UNIT and SCSI_IOCTL_STOP_UNIT. For tapes, those mean load and unload commands. The drive status changes resulting from these commands seem to be caught by st otherwise. I will do a patch for -12rc later today or tomorrow. It may add changing some st status bits if these commands succeed but that is not -stable material. Thanks for the review for all participants. -- Kai - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/