Date: Sat, 30 Apr 2005 16:20:35 +0200
From: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org, Zwane Mwaikambo <zwane@holomorphy.com>,
       Andi Kleen <ak@muc.de>
Subject: Re: 2.6.12-rc3-mm1
Message-ID: <20050430142035.GB3571@stusta.de>
References: <20050429231653.32d2f091.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050429231653.32d2f091.akpm@osdl.org>
User-Agent: Mutt/1.5.9i
To: unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1390
Lines: 50

On Fri, Apr 29, 2005 at 11:16:53PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.12-rc2-mm3:
>...
> +x86-x86_64-deferred-handling-of-writes-to-proc-irq-xx-smp_affinitypatch-added-to-mm-tree.patch
> 
>  x86_64 updates
>...


This patch contains at least two bugs:


The static inline set_irq_info() is not available 
for CONFIG_GENERIC_PENDING_IRQ=n, resulting in the following warning:

<--  snip  -->

...
  CC      arch/i386/kernel/io_apic.o
arch/i386/kernel/io_apic.c: In function `set_ioapic_affinity_irq':
arch/i386/kernel/io_apic.c:251: warning: implicit declaration of function `set_irq_info'
...

<--  snip  -->


The second bug is that although irq.h defines set_irq_info() as a static 
inline, this patch adds an empty function to kernel/irq/manage.c .

The second bug shadows the first bug, but both have to be fixed.


cu
Adrian

BTW: This patch is not in anyway x86_64 specific.

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/