Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261340AbVD3S6m (ORCPT ); Sat, 30 Apr 2005 14:58:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261341AbVD3S6m (ORCPT ); Sat, 30 Apr 2005 14:58:42 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:24078 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S261340AbVD3S6j (ORCPT ); Sat, 30 Apr 2005 14:58:39 -0400 Date: Sat, 30 Apr 2005 20:58:37 +0200 From: Adrian Bunk To: coywolf@lovecn.org Cc: linux-kernel@vger.kernel.org, Zwane Mwaikambo , Andi Kleen Subject: Re: 2.6.12-rc3-mm1 Message-ID: <20050430185837.GI3571@stusta.de> References: <20050429231653.32d2f091.akpm@osdl.org> <20050430142035.GB3571@stusta.de> <2cd57c90050430113078133010@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cd57c90050430113078133010@mail.gmail.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 56 On Sun, May 01, 2005 at 02:30:57AM +0800, Coywolf Qi Hunt wrote: > On 4/30/05, Adrian Bunk wrote: > > On Fri, Apr 29, 2005 at 11:16:53PM -0700, Andrew Morton wrote: > > >... > > > Changes since 2.6.12-rc2-mm3: > > >... > > > +x86-x86_64-deferred-handling-of-writes-to-proc-irq-xx-smp_affinitypatch-added-to-mm-tree.patch > > > > > > x86_64 updates > > >... > > > > This patch contains at least two bugs: > > > > The static inline set_irq_info() is not available > > for CONFIG_GENERIC_PENDING_IRQ=n, resulting in the following warning: > > > > <-- snip --> > > > > ... > > CC arch/i386/kernel/io_apic.o > > arch/i386/kernel/io_apic.c: In function `set_ioapic_affinity_irq': > > arch/i386/kernel/io_apic.c:251: warning: implicit declaration of function `set_irq_info' > > ... > > > > <-- snip --> > > > > The second bug is that although irq.h defines set_irq_info() as a static > > inline, this patch adds an empty function to kernel/irq/manage.c . > > > > The second bug shadows the first bug, but both have to be fixed. > > IMHO, there are no bugs at all, or at least not the kind of bugs you think. It depends on how you define "bug". I agree it was perhaps a too harsh word. What about "Code that could be improved."? ;-) > Coywolf Qi Hunt cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/