Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261309AbVEAW6Q (ORCPT ); Sun, 1 May 2005 18:58:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261357AbVEAW6Q (ORCPT ); Sun, 1 May 2005 18:58:16 -0400 Received: from mail.dif.dk ([193.138.115.101]:38877 "EHLO saerimmer.dif.dk") by vger.kernel.org with ESMTP id S261309AbVEAW5m (ORCPT ); Sun, 1 May 2005 18:57:42 -0400 Date: Mon, 2 May 2005 01:01:11 +0200 (CEST) From: Jesper Juhl To: Andrew Morton Cc: sneakums@zork.net, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, =?ISO-8859-1?Q?Rog=E9rio_Brito?= Subject: Re: 2.6.12-rc3-mm2: ppc pte_offset_map() In-Reply-To: <20050501154654.2bf7606d.akpm@osdl.org> Message-ID: References: <20050430164303.6538f47c.akpm@osdl.org> <6uu0lnf0gm.fsf@zork.zork.net> <20050501154654.2bf7606d.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2791 Lines: 90 On Sun, 1 May 2005, Andrew Morton wrote: > Jesper Juhl wrote: > > > > On Sun, 1 May 2005, Sean Neakums wrote: > > > > > On my Mackertosh (PowerBook5.4), build fails with the following: > > > > > > fs/proc/task_mmu.c: In function `smaps_pte_range': > > > fs/proc/task_mmu.c:177: warning: implicit declaration of function `kmap_atomic' > > > fs/proc/task_mmu.c:177: error: `KM_PTE0' undeclared (first use in this function) > > > fs/proc/task_mmu.c:177: error: (Each undeclared identifier is reported only once > > > fs/proc/task_mmu.c:177: error: for each function it appears in.) > > > fs/proc/task_mmu.c:207: warning: implicit declaration of function `kunmap_atomic' > > > > > > With the naive patch below, it builds with this warning and everything works. > > > > > > fs/proc/task_mmu.c: In function `smaps_pte_range': > > > fs/proc/task_mmu.c:208: warning: passing arg 1 of `kunmap_atomic' makes pointer from integer without a cast > > > > > > > Try this patch : > > > > Signed-off-by: Jesper Juhl > > > > --- linux-2.6.12-rc3-mm2-orig/fs/proc/task_mmu.c 2005-05-01 04:04:25.000000000 +0200 > > +++ linux-2.6.12-rc3-mm2/fs/proc/task_mmu.c 2005-05-01 17:49:14.000000000 +0200 > > @@ -2,6 +2,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -204,7 +205,7 @@ static void smaps_pte_range(pmd_t *pmd, > > } > > } > > } while (address < end); > > - pte_unmap(pte); > > + pte_unmap((void *)pte); > > } > > Should be > > pte_unmap(ptep); > Of course, stupid me. I should have seen the [...] ptep = pte_offset_map(pmd, address); [...] pte = *ptep; address += PAGE_SIZE; ptep++; [...] bit a few lines above. Guess I should have spend more than 2min creating the patch. Thanks. Here's an updated patch. Signed-off-by: Jesper Juhl --- linux-2.6.12-rc3-mm2-orig/fs/proc/task_mmu.c 2005-05-01 04:04:25.000000000 +0200 +++ linux-2.6.12-rc3-mm2/fs/proc/task_mmu.c 2005-05-02 00:59:11.000000000 +0200 @@ -2,6 +2,7 @@ #include #include #include +#include #include #include @@ -204,7 +205,7 @@ static void smaps_pte_range(pmd_t *pmd, } } } while (address < end); - pte_unmap(pte); + pte_unmap(ptep); } static void smaps_pmd_range(pud_t *pud, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/