Message-ID: <42775588.95EB8ECF@tv-sign.ru>
Date: Tue, 03 May 2005 14:42:16 +0400
From: Oleg Nesterov <oleg@tv-sign.ru>
MIME-Version: 1.0
To: Andrew Morton <akpm@osdl.org>
Cc: benh@kernel.crashing.org, jk@blackdown.de, linux-kernel@vger.kernel.org
Subject: Re: 2.6.12-rc2-mm3
References: <20050411012532.58593bc1.akpm@osdl.org>
		<87wtr8rdvu.fsf@blackdown.de>
		<87u0m7aogx.fsf@blackdown.de>
		<1113607416.5462.212.camel@gaston>
		<877jj1aj99.fsf@blackdown.de>
		<20050423170152.6b308c74.akpm@osdl.org>
		<87fyxhj5p1.fsf@blackdown.de>
		<1114308928.5443.13.camel@gaston>
		<426B6C84.E8D41D57@tv-sign.ru> <20050502232925.752ad1d8.akpm@osdl.org>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 833
Lines: 24

Andrew Morton wrote:
> 
> Oleg Nesterov <oleg@tv-sign.ru> wrote:
> >
> > ...
> > Before this timer patch del_timer(pending_timer) worked as
> > a memory barrier for the caller, now it does not.
> >
> 
> I wonder if we should still do this?  It would seem to be a safer approach.
> 
> (This barrier stuff continues to give me the creeps.  Imagine being
> dependent upon accidental barriers in the add/del/mod_timer code.  Ugh).

I can't judge. But if we added barriers now, it would be
very hard to remove them later. And I think it's not good
to have these barriers "just in case".

Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/