Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261670AbVECPME (ORCPT ); Tue, 3 May 2005 11:12:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261702AbVECPME (ORCPT ); Tue, 3 May 2005 11:12:04 -0400 Received: from fed1rmmtao01.cox.net ([68.230.241.38]:53634 "EHLO fed1rmmtao01.cox.net") by vger.kernel.org with ESMTP id S261670AbVECPMB (ORCPT ); Tue, 3 May 2005 11:12:01 -0400 Date: Tue, 3 May 2005 08:11:59 -0700 From: Tom Rini To: David Woodhouse Cc: Russell King , Phil Oester , linux-kernel@vger.kernel.org Subject: Re: Garbage on serial console after serial driver loads Message-ID: <20050503151159.GL1221@smtp.west.cox.net> References: <20050328173652.GA31354@linuxace.com> <20050328200243.C2222@flint.arm.linux.org.uk> <1115129833.4446.23.camel@hades.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1115129833.4446.23.camel@hades.cambridge.redhat.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 24 On Tue, May 03, 2005 at 03:17:12PM +0100, David Woodhouse wrote: > On Mon, 2005-03-28 at 20:02 +0100, Russell King wrote: > > Is this patch ok for you? > > Not really; it's just a quick hack applied without any real > consideration of the problem. If we're messing up the baud rate when we > change the master clock, then just make it change the divisor > accordingly at the same time. We don't seem to store the active > parameters of the serial console anywhere useful; we can do it just by > reading back the divisor and multiplying by eight though... > > Tom, does this also mean you don't need the 'ifndef ppc'? I don't recall the problem well enough right now, but I'll go toss this into a current git tree and let you know. -- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/