Date: Tue, 3 May 2005 10:52:02 -0700
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] PAL-M support fix for CX88 chipsets
Message-Id: <20050503105202.42fa5ffb.rddunlap@osdl.org>
In-Reply-To: <4277B833.9020109@brturbo.com.br>
References: <42777318.2070508@brturbo.com.br>
	<20050503083822.68a116d4.rddunlap@osdl.org>
	<4277B833.9020109@brturbo.com.br>
Organization: OSDL
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1213
Lines: 34

On Tue, 03 May 2005 14:43:15 -0300 Mauro Carvalho Chehab wrote:

| >On Tue, 03 May 2005 09:48:24 -0300 Mauro Carvalho Chehab wrote:
| >
| >|     This patch fixes PAL-M chroma subcarrier frequency (FSC) to its 
| >| correct value of 3.5756115 MHz and adjusts horizontal total samples for 
| >| PAL-M, according with formula Line Draw Time / (4*FSC), where Line Draw 
| >| Time is 63.555 us.
| >|      Without this patch, the Notch subcarrier filter was trying to 
| >| capture using NTSC-M frequency, which is very close, but not equal. This 
| >| could result in Black and White or miscolored frames.


This line:
+        static const unsigned int palm  = 28604892;
begins with spaces, not a TAB.


+	if (V4L2_STD_PAL_M  & norm->id) return palm;
Please only 1 space after the _M, and put the return on a
separate line.

Same comments for the next if/return.

And please clean up the next (final :) version with a
clean description and Signed-off-by: line.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/