Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261502AbVEGCD1 (ORCPT ); Fri, 6 May 2005 22:03:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261505AbVEGCD1 (ORCPT ); Fri, 6 May 2005 22:03:27 -0400 Received: from fire.osdl.org ([65.172.181.4]:52361 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261502AbVEGCDX (ORCPT ); Fri, 6 May 2005 22:03:23 -0400 Date: Fri, 6 May 2005 19:02:12 -0700 From: Andrew Morton To: Jesper Juhl Cc: juhl-lkml@dif.dk, linux-kernel@vger.kernel.org, eokerson@quicknet.net, joe@perches.com Subject: Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only) Message-Id: <20050506190212.0d6a5300.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 607 Lines: 21 This patch adds behavioural changes: - if (j->read_buffer) { - kfree(j->read_buffer); - j->read_buffer = NULL; - j->read_buffer_size = 0; - } + j->read_buffer = NULL; + j->read_buffer_size = 0; Now we'll zero ->read_buffer_size even if ->read_buffer was already NULL. It's hard to believe that this could cause any problems, but please check that. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/