Date: Tue, 10 May 2005 14:40:06 +0200 (CEST)
To: ladis@linux-mips.org
Subject: Re: [PATCH] ds1337 driver works also with ds1339 chip
Message-ID: <u7zs9Dp4.1115728806.6659250.khali@localhost>
In-Reply-To: <20050510120804.GA2492@orphique>
From: "Jean Delvare" <khali@linux-fr.org>
Bounce-To: "Jean Delvare" <khali@linux-fr.org>
CC: "LKML" <linux-kernel@vger.kernel.org>,
       "LM Sensors" <sensors@Stimpy.netroedge.com>,
       "James Chapman" <jchapman@katalix.com>, "Greg KH" <greg@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 999
Lines: 28


Hi Ladislav,

> > next to the end of the ds1337 driver. Maybe it would also make sense to
> > have a ds1337.h header file declaring this function?
>
> I'm not sure if adding yet another driver specific header is a good
> idea. Perhaps we should consolidate I2C RTC drivers a bit more and
> create common header for them?

Agreed, although I would go one step further. I see no reason why it
matters whether these are *I2C* RTC or not. I have no concrete proposal
but it really sounds like a common RTC interface would be needed here -
if it doesn't exist already. Can't say more unfortunately, as I never
had to use a RTC myself.

> Document the fact that ds1337 driver works also with DS1339 real-time
> clock chip.

Good work, thanks.

--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/