Date: Tue, 10 May 2005 10:55:49 -0700
From: Greg KH <gregkh@suse.de>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: Jean Delvare <khali@linux-fr.org>, James Chapman <jchapman@katalix.com>,
       LKML <linux-kernel@vger.kernel.org>,
       LM Sensors <sensors@Stimpy.netroedge.com>
Subject: Re: [PATCH] ds1337: export ds1337_do_command
Message-ID: <20050510175549.GC1530@suse.de>
References: <20050504061438.GD1439@orphique> <1DTwF8-18P-00@press.kroah.org> <20050508204021.627f9cd1.khali@linux-fr.org> <427E6E21.60001@katalix.com> <20050508222351.08bfe2e1.khali@linux-fr.org> <20050510121814.GB2492@orphique>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050510121814.GB2492@orphique>
User-Agent: Mutt/1.5.8i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1087
Lines: 32

On Tue, May 10, 2005 at 02:18:14PM +0200, Ladislav Michl wrote:
> On Sun, May 08, 2005 at 10:23:51PM +0200, Jean Delvare wrote:
> > Hi James,
> > 
> > > I suggest that Ladislav's patch should still be applied and a
> > > separate patch be submitted to export the interface to modules.
> > 
> > Either way is fine with me as long as it actually happens.
> 
> Export ds1337_do_command so it could be used also if driver is built as
> module.
> 
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> 
> --- linux-omap/drivers/i2c/chips/ds1337.c.orig	2005-05-10 14:10:49.637992600 +0200
> +++ linux-omap/drivers/i2c/chips/ds1337.c	2005-05-10 14:13:05.064404656 +0200
> @@ -380,5 +380,7 @@
>  MODULE_DESCRIPTION("DS1337 RTC driver");
>  MODULE_LICENSE("GPL");
>  
> +EXPORT_SYMBOL(ds1337_do_command);

EXPORT_SYMBOL_GPL() ok?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/