Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261234AbVEKO7T (ORCPT ); Wed, 11 May 2005 10:59:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261168AbVEKO7T (ORCPT ); Wed, 11 May 2005 10:59:19 -0400 Received: from mail.tv-sign.ru ([213.234.233.51]:6819 "EHLO several.ru") by vger.kernel.org with ESMTP id S261234AbVEKO6s (ORCPT ); Wed, 11 May 2005 10:58:48 -0400 Message-ID: <42821F65.3FEA7939@tv-sign.ru> Date: Wed, 11 May 2005 19:06:13 +0400 From: Oleg Nesterov X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.20 i686) X-Accept-Language: en MIME-Version: 1.0 To: "David S.Miller" Cc: christoph@lameter.com, akpm@osdl.org, linux-kernel@vger.kernel.org, "Venkatesan, Ganesh" Subject: Re: [RFC][PATCH] timers fixes/improvements References: <42808B84.BCC00574@tv-sign.ru> <20050510.125301.59655362.davem@davemloft.net> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 598 Lines: 16 Btw, i think that drivers/net/e1000/e1000_main.c:e1000_down() is buggy. It calls del_timer_sync(&adapter->watchdog_timer), but e1000_watchdog() calls schedule_work(e1000_watchdog_task), so the work could be queued after del_timer_sync(). And e1000_watchdog_task() arms timers again. Note that it's not enough to do flush_scheduled_work() here. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/