Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261181AbVEKPNa (ORCPT ); Wed, 11 May 2005 11:13:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261195AbVEKPN3 (ORCPT ); Wed, 11 May 2005 11:13:29 -0400 Received: from graphe.net ([209.204.138.32]:62478 "EHLO graphe.net") by vger.kernel.org with ESMTP id S261181AbVEKPMV (ORCPT ); Wed, 11 May 2005 11:12:21 -0400 Date: Wed, 11 May 2005 08:12:16 -0700 (PDT) From: Christoph Lameter X-X-Sender: christoph@graphe.net To: Oleg Nesterov cc: Andrew Morton , linux-kernel@vger.kernel.org, mingo@elte.hu, kenneth.w.chen@intel.com, shai@scalex86.org Subject: Re: [RFC][PATCH] timers fixes/improvements In-Reply-To: <4281DC03.36011256@tv-sign.ru> Message-ID: References: <424D373F.1BCBF2AC@tv-sign.ru> <424E6441.12A6BC03@tv-sign.ru> <20050509144255.17d3b9aa.akpm@osdl.org> <42808B84.BCC00574@tv-sign.ru> <4281DC03.36011256@tv-sign.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -5.9 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 34 On Wed, 11 May 2005, Oleg Nesterov wrote: > > However, if the padding is put before ptype_base and after ptype_all > > then the problem occurs. > > So. ptype_base/ptype_all is corrupted before e1000_probe()->register_netdev(). > > Christoph, please, could you try this patch? We found that this has nothing to do with the timer patches. There is a scribble in pcie_rootport_aspm_quirk that overwrites ptype_all. quirk_aspm_offset[GET_INDEX(pdev->device, dev->devfn)]= cap_base + 0x10; does the evil deed. The array offset calculated by GET_INDEX is out of bounds. The definition of GET_INDEX is suspect: #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + b) should this not be #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + \ ((b) & 7)) ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/